lkml.org 
[lkml]   [2012]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set
On Thu, Jul 26, 2012 at 02:22:48PM +0200, Markus Trippelsdorf wrote:
> Every time I start qemu-kvm on my system the following line is added to
> the syslog:
>
> vcpu0 unhandled rdmsr: 0xc0010001
>
> AFAICS all calls to vcpu_unimpl only contain debugging info with little
> or no value for the end user.
>
> Wouldn't something like the following patch make sense?
>
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>

It could be useful for debugging (but then lots of other things could).

Anyone has a use for this?

> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index b70b48b..6bd816f 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -321,7 +321,7 @@ struct kvm {
> #define kvm_debug(fmt, ...) \
> pr_debug("kvm [%i]: " fmt, task_pid_nr(current), ## __VA_ARGS__)
> #define kvm_pr_unimpl(fmt, ...) \
> - pr_err_ratelimited("kvm [%i]: " fmt, \
> + pr_debug_ratelimited("kvm [%i]: " fmt, \
> task_tgid_nr(current), ## __VA_ARGS__)
>
> /* The guest did something we don't support. */
>
> --
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


\
 
 \ /
  Last update: 2012-08-01 06:01    [W:0.067 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site