lkml.org 
[lkml]   [2012]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 46/73] target: Check number of unmap descriptors against our limit
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Roland Dreier <roland@purestorage.com>

    commit 7409a6657aebf8be74c21d0eded80709b27275cb upstream.

    Fail UNMAP commands that have more than our reported limit on unmap
    descriptors.

    Signed-off-by: Roland Dreier <roland@purestorage.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    [bwh: Backported to 3.2: adjust filename]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/target/target_core_cdb.c | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/drivers/target/target_core_cdb.c
    +++ b/drivers/target/target_core_cdb.c
    @@ -1133,6 +1133,11 @@ int target_emulate_unmap(struct se_task
    bd_dl = get_unaligned_be16(&buf[2]);

    size = min(size - 8, bd_dl);
    + if (size / 16 > dev->se_sub_dev->se_dev_attrib.max_unmap_block_desc_count) {
    + cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST;
    + ret = -EINVAL;
    + goto err;
    + }

    /* First UNMAP block descriptor starts at 8 byte offset */
    ptr = &buf[8];



    \
     
     \ /
      Last update: 2012-07-31 07:41    [W:3.131 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site