lkml.org 
[lkml]   [2012]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] regulator: wm831x-ldo: Check return value of wm831x_reg_read()
    From
    Date
    wm831x_reg_read() returns negative error code on failure.
    This prevents using the error code as the value read.

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    drivers/regulator/wm831x-ldo.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/regulator/wm831x-ldo.c b/drivers/regulator/wm831x-ldo.c
    index 5cb70ca..56a6de3 100644
    --- a/drivers/regulator/wm831x-ldo.c
    +++ b/drivers/regulator/wm831x-ldo.c
    @@ -205,6 +205,8 @@ static int wm831x_gp_ldo_get_status(struct regulator_dev *rdev)

    /* Is it reporting under voltage? */
    ret = wm831x_reg_read(wm831x, WM831X_LDO_UV_STATUS);
    + if (ret < 0)
    + return ret;
    if (ret & mask)
    return REGULATOR_STATUS_ERROR;

    @@ -469,6 +471,8 @@ static int wm831x_aldo_get_status(struct regulator_dev *rdev)

    /* Is it reporting under voltage? */
    ret = wm831x_reg_read(wm831x, WM831X_LDO_UV_STATUS);
    + if (ret < 0)
    + return ret;
    if (ret & mask)
    return REGULATOR_STATUS_ERROR;

    --
    1.7.9.5




    \
     
     \ /
      Last update: 2012-07-31 16:01    [W:0.035 / U:0.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site