Messages in this thread | | | Subject | Re: [PATCH V2] dma: tegra: enable/disable dma clock | From | Vinod Koul <> | Date | Tue, 31 Jul 2012 12:18:44 +0530 |
| |
On Fri, 2012-07-27 at 13:42 +0530, Laxman Dewangan wrote: > On Tuesday 24 July 2012 10:30 AM, Laxman Dewangan wrote: > > On Tuesday 24 July 2012 10:38 AM, Vinod Koul wrote: > >> On Fri, 2012-07-20 at 13:31 +0530, Laxman Dewangan wrote: > >>> Enable the DMA clock when allocating channel and > >>> disable clock when freeing channels. > >>> > >>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com> > >>> --- > >>> + clk_disable_unprepare(tdma->dma_clk); > >> What if another channel is active, disabling clock can cause bad > >> behavior. You should check here if all channels are idle and then > >> disable, or is this handled by clock API? > > Yes, clock driver keeps the reference count and so client driver need > > not to take care. > > > Hi Vinod, > Is there any thing remaining from my side here? Nope, I will take care of it > Is it possible to make it for K3.6? Nope 3.6 is released, too late for that
-- ~Vinod
| |