Messages in this thread | | | Date | Mon, 30 Jul 2012 21:58:26 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 0/6] menuconfig: jump to search results |
| |
On Mon, Jul 30, 2012 at 03:22:04PM -0400, Benjamin Poirier wrote: > Hello, > > This patch series adds "jump to" keys (similar to the cscope interface) to the > search results of "make menuconfig" so that we can go directly to the menu > entry for a config option after searching for it. > > Patches 1-4 implement the basic functionnality. > Patches 5-6 are an optionnal improvement.
Generally,
a nice idea, I like it.
A couple of notes though:
* patches 2/6 and 3/6 don't have commit messages and it would be good if they had, even though it is obvious what the changes in there do.
* this patchset must be against some kbuild tree because it doesn't apply against 3.5:
$ patch -p1 --dry-run -i ~/0001-menuconfig_extend_dialog_textbox_so_that_it_can_exit_on_arbitrary_keypresses.patch patching file scripts/kconfig/lxdialog/dialog.h patching file scripts/kconfig/lxdialog/textbox.c Hunk #3 FAILED at 132. Hunk #4 succeeded at 157 (offset -1 lines). Hunk #5 succeeded at 172 (offset -1 lines). Hunk #6 succeeded at 252 (offset -3 lines). Hunk #7 succeeded at 261 (offset -3 lines). 1 out of 7 hunks FAILED -- saving rejects to file scripts/kconfig/lxdialog/textbox.c.rej patching file scripts/kconfig/mconf.c
Thanks.
-- Regards/Gruss, Boris.
| |