lkml.org 
[lkml]   [2012]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data
    On 30.07.2012 19:32, Evgeniy Polyakov wrote:
    > Hi
    >
    > Sorry for long delay
    >
    > On Wed, Jul 25, 2012 at 10:54:29PM +0200, Daniel Mack (zonque@gmail.com) wrote:
    >> In the process of porting boards to devicetree implemenation, we should
    >> keep information about external circuitry where they belong - the
    >> individual drivers.
    >>
    >> This patch adds a way to specify a GPIO to drive the (optional) external
    >> pull-up logic, rather than using a function pointer for that.
    >
    > I do not object against this patch, but I have rather limited knowledge
    > about gpio driver.

    The first patch just offers a new way to drive an optional external
    pull-up and as nobody uses that feature currently, there can't be any
    breakage.

    And the second patch doesn't change any functional behaviour of the
    driver, it simply offers a new way to instanciate it.

    > Patch looks good, feel free to add my
    > Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

    Thanks!

    >
    > Greg, please pull it into your tree, if Ville does not object.
    > Thank you.
    >



    \
     
     \ /
      Last update: 2012-07-30 20:41    [W:0.027 / U:0.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site