lkml.org 
[lkml]   [2012]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] aerdrv: Enable AER completion notice
On Thu, Jul 19, 2012 at 1:19 PM, Lance Ortiz <lance.ortiz@hp.com> wrote:
> When an AER event occurs not all of the print notifications are at the
> same log level. This can cause an incomplete AER log from the users
> point of view when monitoring the console output.
>
> The completion message in do_recovery() is currently set to KERN_DEBUG
> (log level 7) while the starting message in aer_port_info() uses
> KERN_INFO(log level 6). The completion message should be set to
> KERN_INFO so it is consistent with the starting message in the log.
>
> The message has also been re-worded to make it more clear. This patch
> will enable the AER log on the console output to be book-ended by a
> clear and consistent starting and completion message.
>
> Signed-off-by: Lance Ortiz <lance.ortiz@hp.com>
> ---
> drivers/pci/pcie/aer/aerdrv_core.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
> index 0ca0535..164bab5 100644
> --- a/drivers/pci/pcie/aer/aerdrv_core.c
> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> @@ -540,14 +540,14 @@ static void do_recovery(struct pci_dev *dev, int severity)
> "resume",
> report_resume);
>
> - dev_printk(KERN_DEBUG, &dev->dev,
> - "AER driver successfully recovered\n");
> + dev_printk(KERN_INFO, &dev->dev,
> + "AER: Device recovery successful\n");
> return;
>
> failed:
> /* TODO: Should kernel panic here? */
> - dev_printk(KERN_DEBUG, &dev->dev,
> - "AER driver didn't recover\n");
> + dev_printk(KERN_INFO, &dev->dev,
> + "AER: Device recovery failed\n");
> }
>
> /**

I applied this with minor tweaks (using dev_info() rather than
dev_printk(KERN_INFO)).

It won't appear in my "next" branch until I rebuild it after the merge
window closes.

Thanks!


\
 
 \ /
  Last update: 2012-07-30 20:41    [W:0.038 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site