Messages in this thread | | | Date | Mon, 30 Jul 2012 08:41:30 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [ 13/40] vmscan: shrinker->nr updates race and go wrong |
| |
On Mon, Jul 30, 2012 at 10:06:45AM +0100, Mel Gorman wrote: > On Sun, Jul 29, 2012 at 09:29:30PM +0100, Ben Hutchings wrote: > > > --- a/mm/vmscan.c > > > +++ b/mm/vmscan.c > > > @@ -251,17 +251,29 @@ unsigned long shrink_slab(struct shrink_ > > > unsigned long total_scan; > > [...] > > > + total_scan += delta; > > > + if (total_scan < 0) { > > [...] > > > > This condition is never true since total_scan is unsigned. > > I think 3.0.y needs this as well: > > > > commit 635697c663f38106063d5659f0cf2e45afcd4bb5 > > Author: Konstantin Khlebnikov <khlebnikov@openvz.org> > > Date: Thu Dec 8 14:33:51 2011 -0800 > > > > vmscan: fix initial shrinker size handling > > > > You're right, thanks for pointing it out as I missed it. Greg, this commit > is already in 3.2 but can you pick it up for 3.0-stable please? > > ---8<--- > vmscan: fix initial shrinker size handling > > commit 635697c663f38106063d5659f0cf2e45afcd4bb5 upstream.
Now applied, thanks.
greg k-h
| |