lkml.org 
[lkml]   [2012]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH TRIVIAL] mm: Fix build warning in kmem_cache_create()
    From
    On Sat, Jul 14, 2012 at 2:12 AM, Shuah Khan <shuah.khan@hp.com> wrote:
    > The label oops is used in CONFIG_DEBUG_VM ifdef block and is defined
    > outside ifdef CONFIG_DEBUG_VM block. This results in the following
    > build warning when built with CONFIG_DEBUG_VM disabled. Fix to move
    > label oops definition to inside a CONFIG_DEBUG_VM block.
    >
    > mm/slab_common.c: In function ‘kmem_cache_create’:
    > mm/slab_common.c:101:1: warning: label ‘oops’ defined but not used
    > [-Wunused-label]
    >
    > Signed-off-by: Shuah Khan <shuah.khan@hp.com>

    I merged this as an obvious and safe fix for current merge window. We
    need to clean this up properly for v3.7.

    > ---
    > mm/slab_common.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/mm/slab_common.c b/mm/slab_common.c
    > index 12637ce..aa3ca5b 100644
    > --- a/mm/slab_common.c
    > +++ b/mm/slab_common.c
    > @@ -98,7 +98,9 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size, size_t align
    >
    > s = __kmem_cache_create(name, size, align, flags, ctor);
    >
    > +#ifdef CONFIG_DEBUG_VM
    > oops:
    > +#endif
    > mutex_unlock(&slab_mutex);
    > put_online_cpus();
    >
    > --
    > 1.7.9.5
    >
    >
    >
    > --
    > To unsubscribe, send a message with 'unsubscribe linux-mm' in
    > the body to majordomo@kvack.org. For more info on Linux MM,
    > see: http://www.linux-mm.org/ .
    > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-07-30 13:01    [W:0.025 / U:152.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site