lkml.org 
[lkml]   [2012]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] fs/sysv: remove another useless write_super call
    Date
    From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

    We do not need to call 'sysv_write_super()' from 'sysv_remount()',
    because VFS has called 'sysv_sync_fs()' before calling '->remount()'.
    So remove it. Remove also '(un)lock_super()' which obvioulsy is becoming
    useless in this function.

    Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
    ---
    fs/sysv/inode.c | 5 +----
    1 files changed, 1 insertions(+), 4 deletions(-)

    diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c
    index af13d13..f20ffe3 100644
    --- a/fs/sysv/inode.c
    +++ b/fs/sysv/inode.c
    @@ -68,12 +68,9 @@ static void sysv_write_super(struct super_block *sb)
    static int sysv_remount(struct super_block *sb, int *flags, char *data)
    {
    struct sysv_sb_info *sbi = SYSV_SB(sb);
    - lock_super(sb);
    +
    if (sbi->s_forced_ro)
    *flags |= MS_RDONLY;
    - if (*flags & MS_RDONLY)
    - sysv_write_super(sb);
    - unlock_super(sb);
    return 0;
    }

    --
    1.7.7.6


    \
     
     \ /
      Last update: 2012-07-03 16:21    [W:0.023 / U:148.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site