Messages in this thread Patch in this message |  | | | From | Roland Dreier <> | | Subject | [PATCH] misc: mei: set IRQF_ONESHOT for MSI request_threaded_irq() in mei_pci_resume() | | Date | Tue, 3 Jul 2012 02:08:30 -0700 |
| |
From: Roland Dreier <roland@purestorage.com>
When the default quick IRQ handler is used then IRQF_ONESHOT must be set, or else the request fails and following error is logged on resume:
genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq ...
This is the same fix that commit aa189ecdc0c7 ("misc: mei: set IRQF_ONESHOT for msi request_threaded_irq") did in the probe function.
Reported-by: Lekensteyn <lekensteyn@gmail.com> Signed-off-by: Roland Dreier <roland@purestorage.com> --- Can you try this? It looks to be needed. Thomas/Greg, I think this should get into 3.5 if possible.
drivers/misc/mei/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 7de1389..783fcd7 100644 --- a/drivers/misc/mei/main.c +++ b/drivers/misc/mei/main.c @@ -1147,7 +1147,7 @@ static int mei_pci_resume(struct device *device) err = request_threaded_irq(pdev->irq, NULL, mei_interrupt_thread_handler, - 0, mei_driver_name, dev); + IRQF_ONESHOT, mei_driver_name, dev); else err = request_threaded_irq(pdev->irq, mei_interrupt_quick_handler, -- 1.7.10.4
|  |