lkml.org 
[lkml]   [2012]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] gpio-sch: Fix leak of resource
From
On Tue, Jul 24, 2012 at 2:55 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> From: Alan Cox <alan@linux.intel.com>
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/gpio/gpio-sch.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
> index 424dce8..8707d45 100644
> --- a/drivers/gpio/gpio-sch.c
> +++ b/drivers/gpio/gpio-sch.c
> @@ -241,7 +241,8 @@ static int __devinit sch_gpio_probe(struct platform_device *pdev)
> break;
>
> default:
> - return -ENODEV;
> + err = -ENODEV;
> + goto err_sch_gpio_core;
> }
>
> sch_gpio_core.dev = &pdev->dev;

Applied to my fixes branch, CCing the list if there are complaints.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2012-07-29 18:41    [W:0.029 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site