lkml.org 
[lkml]   [2012]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ixp4xx: Declare MODULE_FIRMWARE usage
Date
Tim Gardner <tim.gardner@canonical.com> writes:

> +++ b/arch/arm/mach-ixp4xx/ixp4xx_npe.c
> @@ -116,7 +116,11 @@
> /* NPE mailbox_status value for reset */
> #define RESET_MBOX_STAT 0x0000F0F0
>
> -const char *npe_names[] = { "NPE-A", "NPE-B", "NPE-C" };
> +#define NPE_A_FIRMWARE "NPE-A"
> +#define NPE_B_FIRMWARE "NPE-B"
> +#define NPE_C_FIRMWARE "NPE-C"
> +
> +const char *npe_names[] = { NPE_A_FIRMWARE, NPE_B_FIRMWARE, NPE_C_FIRMWARE };
>
> #define print_npe(pri, npe, fmt, ...) \
> printk(pri "%s: " fmt, npe_name(npe), ## __VA_ARGS__)
> @@ -724,6 +728,9 @@ module_exit(npe_cleanup_module);
>
> MODULE_AUTHOR("Krzysztof Halasa");
> MODULE_LICENSE("GPL v2");
> +MODULE_FIRMWARE(NPE_A_FIRMWARE);
> +MODULE_FIRMWARE(NPE_B_FIRMWARE);
> +MODULE_FIRMWARE(NPE_C_FIRMWARE);
>
> EXPORT_SYMBOL(npe_names);
> EXPORT_SYMBOL(npe_running);

This looks like a good idea, thanks.
--
Krzysztof Halasa


\
 
 \ /
  Last update: 2012-07-28 14:01    [W:0.049 / U:0.376 seconds]
©2003-2014 Jasper Spaans. Advertise on this site