[lkml]   [2012]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/4] promote zcache from staging
On Fri, Jul 27, 2012 at 12:21:50PM -0700, Dan Magenheimer wrote:
> > From: Seth Jennings []
> > Subject: [PATCH 0/4] promote zcache from staging
> >
> > zcache is the remaining piece of code required to support in-kernel
> > memory compression. The other two features, cleancache and frontswap,
> > have been promoted to mainline in 3.0 and 3.5. This patchset
> > promotes zcache from the staging tree to mainline.
> >
> > Based on the level of activity and contributions we're seeing from a
> > diverse set of people and interests, I think zcache has matured to the
> > point where it makes sense to promote this out of staging.
> Hi Seth --
> Per offline communication, I'd like to see this delayed for three
> reasons:
> 1) I've completely rewritten zcache and will post the rewrite soon.
> The redesigned code fixes many of the weaknesses in zcache that
> makes it (IMHO) unsuitable for an enterprise distro. (Some of
> these previously discussed in linux-mm [1].)
> 2) zcache is truly mm (memory management) code and the fact that
> it is in drivers at all was purely for logistical reasons
> (e.g. the only in-tree "staging" is in the drivers directory).
> My rewrite promotes it to (a subdirectory of) mm where IMHO it
> belongs.
> 3) Ramster heavily duplicates code from zcache. My rewrite resolves
> this. My soon-to-be-post also places the re-factored ramster
> in mm, though with some minor work zcache could go in mm and
> ramster could stay in staging.
> Let's have this discussion, but unless the community decides
> otherwise, please consider this a NACK.

Hold on, that is rather unfair. The zcache has been in staging
for quite some time - your code has not been posted. Part of
"unstaging" a driver is for folks to review the code - and you
just said "No, mine is better" without showing your goods.

There is a third option - which is to continue the promotion
of zcache from staging, get reviews, work on them ,etc, and
alongside of that you can work on fixing up (or ripping out)
zcache1 with zcache2 components as they make sense. Or even
having two of them - an enterprise and an embedded version
that will eventually get merged together. There is nothing
wrong with modifying a driver once it has left staging.

 \ /
  Last update: 2012-07-27 23:21    [W:0.105 / U:0.980 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site