lkml.org 
[lkml]   [2012]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/6] rbtree: faster augmented insert
    From
    Date
    On Fri, 2012-07-20 at 05:31 -0700, Michel Lespinasse wrote:
    > +static void augment_rotate(struct rb_node *rb_old, struct rb_node *rb_new)
    > +{
    > + struct test_node *old = rb_entry(rb_old, struct test_node, rb);
    > + struct test_node *new = rb_entry(rb_new, struct test_node, rb);
    > +
    > + /* Rotation doesn't change subtree's augmented value */
    > + new->augmented = old->augmented;
    > + old->augmented = augment_recompute(old);
    > +}

    > +static inline void augment_propagate(struct rb_node *rb)
    > +{
    > + while (rb) {
    > + struct test_node *node = rb_entry(rb, struct test_node, rb);
    > + node->augmented = augment_recompute(node);
    > + rb = rb_parent(&node->rb);
    > + }
    > +}

    So why do we have to introduce these two new function pointers to pass
    along when they can both be trivially expressed in the old single
    augment function?




    \
     
     \ /
      Last update: 2012-07-27 22:41    [W:0.023 / U:2.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site