lkml.org 
[lkml]   [2012]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] charger-manager: Use replacement variable to check state of battery
    Date
    This patch remove unnecessary variable(cm->fullbatt_vchk_uV) by using
    'desc->fullbatt_uV' field directly in fullbatt_handler() function
    to check the state of battery.

    Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
    Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com>
    Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
    ---
    drivers/power/charger-manager.c | 2 +-
    include/linux/power/charger-manager.h | 3 ---
    2 files changed, 1 insertions(+), 4 deletions(-)

    diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
    index 240de49..cdf29d2 100644
    --- a/drivers/power/charger-manager.c
    +++ b/drivers/power/charger-manager.c
    @@ -415,7 +415,7 @@ static void fullbatt_vchk(struct work_struct *work)
    return;
    }

    - diff = cm->fullbatt_vchk_uV;
    + diff = desc->fullbatt_uV;
    diff -= batt_uV;

    dev_dbg(cm->dev, "VBATT dropped %duV after full-batt.\n", diff);
    diff --git a/include/linux/power/charger-manager.h b/include/linux/power/charger-manager.h
    index cd22029..7d7b90f 100644
    --- a/include/linux/power/charger-manager.h
    +++ b/include/linux/power/charger-manager.h
    @@ -194,8 +194,6 @@ struct charger_desc {
    * @charger_enabled: the state of charger
    * @fullbatt_vchk_jiffies_at:
    * jiffies at the time full battery check will occur.
    - * @fullbatt_vchk_uV: voltage in microvolt
    - * criteria for full battery
    * @fullbatt_vchk_work: work queue for full battery check
    * @emergency_stop:
    * When setting true, stop charging
    @@ -218,7 +216,6 @@ struct charger_manager {
    bool charger_enabled;

    unsigned long fullbatt_vchk_jiffies_at;
    - unsigned int fullbatt_vchk_uV;
    struct delayed_work fullbatt_vchk_work;

    int emergency_stop;
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2012-07-27 07:41    [W:0.021 / U:60.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site