Messages in this thread | | | Date | Thu, 26 Jul 2012 18:38:49 +0900 | From | Tomoki Sekiyama <> | Subject | Re: [PATCH] x86/ioapic: Fix NULL pointer dereference on CPU hotplug after disabling irqs |
| |
Hi, thanks for your comment.
On 2012/07/26 8:28, Siddha, Suresh B wrote: > Tomoki wrote: >> In current Linux, percpu variable `vector_irq' is not always cleared when >> a CPU is offlined. If the cpu that has the disabled irqs in vector_irq is >> hotplugged again, __setup_vector_irq() hits invalid irq vector and may >> crash. >> >> Commit f6175f5bfb4c partially fixes this, but was not enough in >> environments with IOMMU IRQ remapper. > > So, this patch essentially makes the commit f6175f5bfb4c unnecessary, right? > > Can you revert that too as part of this new proposed patch? > > thanks, > suresh
OK, I will include a reverse patch of f6175f5bfb4c and resend the patch.
Thanks, -- Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com> Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory
| |