Messages in this thread | | | Date | Fri, 27 Jul 2012 08:17:50 +1000 | From | Peter Chubb <> | Subject | Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC |
| |
>>>>> "Ingo" == Ingo Molnar <mingo@kernel.org> writes:
Ingo> * James Bottomley <James.Bottomley@HansenPartnership.com> wrote: >> Since the problem is an invalid assumption about how the stack >> grows, why not just condition it on that. We actually have a >> config option for this: CONFIG_STACK_GROWSUP. But for some reason >> ia64 doesn't define this, why not, Tony? It looks deliberate >> because you have replaced a lot of >> >> #ifdef CONFIG_STACK_GROWSUP >> >> with >> >> #if defined(CONFIG_STACK_GROWSUP) || defined(CONFIG_IA64) >> >> but not all of them.
Ingo> Yes, that's another possible solution, assuming that it's really Ingo> only about the up/down difference.
Ingo> Thanks,
IA64 has two stacks -- the standard one, that grows down, and the register stack engine backing store, that grows up. The usual mechanisms for stack growth are used, so only some of the bits predicated on `STACK_GROWSUP' are useful.
Peter C -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA
| |