Messages in this thread | | | Date | Thu, 26 Jul 2012 13:17:17 +0800 | From | Aaron Lu <> | Subject | Re: [git patches] libata updates |
| |
On 07/26/2012 01:05 PM, James Bottomley wrote: > On Thu, 2012-07-26 at 12:47 +0800, Aaron Lu wrote: >> On 07/26/2012 05:38 AM, Jeff Garzik wrote: >>> On 07/25/2012 04:35 PM, Jeff Garzik wrote: >>>> * Updating libata to directly bind with ACPI / runtime power mgmt. >>>> This is a pre-req for SATA ZPODD (CD-ROM power management). >>>> >>>> Touches ACPI (exports++) and SCSI in minor ways. Has been in linux-next >>>> for weeks. >>>> >>>> The rest of [ZPODD] will probably come via SCSI tree, as it involves >>>> a lot of updates to the 'sr' driver etc. >>> >>> BTW Lin and Aaron, note that this did not include these changes: >>> >>> sr: check support for device busy class events >>> sr: support zero power ODD >>> sr: make sure ODD is in resumed state in block ioctl >>> >>> as in the end I wanted to put the brakes on SCSI-touching patches. These >>> should be able to go into James' scsi-misc tree with the other SCSI-area >>> ZPODD changes. >>> >>> For those three 'sr' changes listed above, you may add >>> >>> Acked-by: Jeff Garzik<jgarzik@redhat.com> >>> >>> when moving them over. >> >> Thanks Jeff. >> >> Hi James, >> I'll prepare these dropped patches plus some other fixes for ZPODD which >> I've sent v2 recently and merge them into v3 for you to review. > > They weren't exactly dropped ... I've been waiting for you to address > Alan Stern's comments, since he's our resident expert on suspend/resume.
Oh, I forgot to mention, that I agree with Alan's comments and have addressed them in my v2 patches here: http://marc.info/?l=linux-scsi&m=134312317325650&w=2
The 2 patches Alan has comments are: http://marc.info/?l=linux-scsi&m=134312311025619&w=2 http://marc.info/?l=linux-scsi&m=134312308225610&w=2
Hi Alan, Are the v2 patches look OK to you?
And James, Do you want me to rebase these patches on top of scsi-misc tree?
Thanks, Aaron
| |