lkml.org 
[lkml]   [2012]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 19/21] ASoC: Ux500: Enable ux500 MSP driver for Device Tree
On Thu, Jul 26, 2012 at 11:28:52AM +0100, Lee Jones wrote:

> arch/arm/mach-ux500/board-mop500-msp.c | 14 --------------
> arch/arm/mach-ux500/board-mop500.c | 2 --
> arch/arm/mach-ux500/board-mop500.h | 2 --
> sound/soc/ux500/ux500_msp_dai.c | 6 ++++++
> sound/soc/ux500/ux500_msp_i2s.c | 33 +++++++++++++++++++++++++++++---

Always provide documentation for DT bindings.

> +void ux500_msp_i2s_of_init_msp(struct platform_device *pdev,
> + struct ux500_msp *msp,
> + struct device_node *np)
> +{
> + if (of_get_property(np, "stericsson,use-pinctrl", NULL))
> + msp->use_pinctrl = true;
> + else
> + msp->use_pinctrl = false;
> +}
> +

This doesn't seem particularly sane... why is this conditional?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-07-26 14:21    [W:0.320 / U:0.500 seconds]
©2003-2014 Jasper Spaans. Advertise on this site