Messages in this thread | | | Date | Thu, 26 Jul 2012 10:30:18 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 3/4] uprobes: rename vma_address() and make it return "unsigned long" |
| |
* Oleg Nesterov <oleg@redhat.com> [2012-07-12 19:10:22]:
> 1. vma_address() returns loff_t, this looks confusing and this is > unnecessary after the previous change. Make it return "ulong", > all callers truncate the result anyway. > > 2. Its name conflicts with mm/rmap.c:vma_address(), rename it to > offset_to_vaddr(), this matches vaddr_to_offset(). > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
| |