| Date | Thu, 26 Jul 2012 10:40:11 +0800 | Subject | Re: [RFC PATCH 07/13] driver core: firmware loader: introduce cache_firmware and uncache_firmware | From | Ming Lei <> |
| |
On Wed, Jul 25, 2012 at 11:52 PM, Borislav Petkov <bp@amd64.org> wrote: > > You have similar functionality in fw_lookup_and_alloate_buf() above. > Can't you reuse it instead of defining a new function?
The problem is that the lock can't be released between lookup and allocate inside fw_lookup_and_alloate_buf(). I will try to introduce __fw_lookup_buf and reuse it in both fw_lookup_and_alloate_buf and fw_lookup_buf.
Also will fix the comments and code style you mentioned in -v1.
Thanks, -- Ming Lei
|