lkml.org 
[lkml]   [2012]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 0/4] ACPI: hotplug messages improvement
From
Date
On Wed, 2012-07-25 at 16:31 -0700, Joe Perches wrote:
> On Wed, 2012-07-25 at 17:12 -0600, Toshi Kani wrote:
> > This patchset improves logging messages for ACPI CPU, Memory, and
> > Container hotplug notify handlers. The patchset introduces a set of
> > new macro interfaces, acpi_pr_<level>(), and updates the notify
> > handlers to use them. acpi_pr_<level>() appends "ACPI" prefix and
> > ACPI object path to the messages, and its usage model is similar to
> > dev_<level>(). This improves diagnostics in hotplug operations
> > since it identifies an object that caused an issue in a log file.
> >
> > v3:
> > - Changed acpi_pr_debug() to NOP when !DEBUG and !DYNAMIC_DEBUG.
> > DYNAMIC_DEBUG will be supported later.
> > - Added const to a path variable in acpi_printk().
> > - Added more descriptions to the change log of patch 1/4.
>
> Thanks Toshi.
>
> This seems sensible to me. I've no more comments either.

Thanks Joe for the valuable suggestions!
-Toshi





\
 
 \ /
  Last update: 2012-07-26 02:21    [from the cache]
©2003-2011 Jasper Spaans