Messages in this thread |  | | | Date | Wed, 25 Jul 2012 13:18:06 -0700 | | From | "H. Peter Anvin" <> | | Subject | Re: [GIT PULL] x86/build change for v3.6 |
| |
On 07/25/2012 01:15 PM, Sam Ravnborg wrote: > > This is not as expected.... > In this silly example it is maybe obvious but I have lost hours tracking > down bugs due to this. > You add a new target and suddenly someting unrelated breaks. > > What happens is that make consider the assignment a command due to the leading > tab - and because is follows a target (or other commands). > > I hope this makes it clear why many makefiles in the kernel uses tabs for indent. >
This is also a good reason why not to indent assignments in Makefiles by full tab stops. A smaller indent can't be scrambled this way.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
|  |