lkml.org 
[lkml]   [2012]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH] ia64: rename platform_* to ia64_platform_*
From
Date
On Wed, 2012-07-25 at 18:37 +0000, Luck, Tony wrote:
> >> Is platform_name particularly special?
>
> Yes. It is the symbol that is currently colliding with other subsystem namespace.
>
> >> Perhaps it's be better to rename all the other
> >> platform_<foo> uses to ia64_platform_<foo>
> >
> > That's good point in general, oh well I just wanted to make the minimal change..
>
> Following that logic there isn't anything special about symbols starting with
> "platform" ... and we should hunt down every global symbol in every architecture
> that is local to the architecture and replace it with $arch_$symbol.
>
> I think I'll just take the minimal patch to fix "platform_name" and continue to
> use a "fix as problems occur" algorithm to the namespace pollution problem.

That can lead to a lot of naming inconsistencies.



\
 
 \ /
  Last update: 2012-07-25 21:21    [W:0.043 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site