Messages in this thread | | | Date | Wed, 25 Jul 2012 13:54:07 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH 4/6] rbtree: faster augmented insert |
| |
On 07/20/2012 08:31 AM, Michel Lespinasse wrote: > Introduce rb_insert_augmented(), which is a version of rb_insert_color() > with an added callback on tree rotations. This can be used for insertion > into an augmented tree: the handcoded search phase must be updated to > maintain the augmented information on insertion, and then the rbtree > coloring/rebalancing algorithms keep it up to date. > > rb_insert_color() is now a special case of rb_insert_augmented() with > a do-nothing callback. I used inlining to optimize out the callback, > with the intent that this would generate the same code as previously > for rb_insert_augmented(). This didn't fully work, as my compiler output > is now *smaller* than before for that function. Speed wise, they seem > comparable though. > > Signed-off-by: Michel Lespinasse <walken@google.com>
The second version of patch 5/6 takes care of my concerns about this patch.
Acked-by: Rik van Riel <riel@redhat.com>
| |