lkml.org 
[lkml]   [2012]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 16/16] UBIFS: nuke pdflush from comments
    Date
    From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

    The pdflush thread is long gone, so this patch removes references to pdflush
    from UBIFS comments.

    Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
    ---

    I expect this patch to be merged via Al Viro's VFS tree.

    fs/ubifs/file.c | 10 +++++-----
    fs/ubifs/super.c | 2 +-
    2 files changed, 6 insertions(+), 6 deletions(-)

    diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
    index 35389ca..7bd6e72 100644
    --- a/fs/ubifs/file.c
    +++ b/fs/ubifs/file.c
    @@ -37,11 +37,11 @@
    *
    * A thing to keep in mind: inode @i_mutex is locked in most VFS operations we
    * implement. However, this is not true for 'ubifs_writepage()', which may be
    - * called with @i_mutex unlocked. For example, when pdflush is doing background
    - * write-back, it calls 'ubifs_writepage()' with unlocked @i_mutex. At "normal"
    - * work-paths the @i_mutex is locked in 'ubifs_writepage()', e.g. in the
    - * "sys_write -> alloc_pages -> direct reclaim path". So, in 'ubifs_writepage()'
    - * we are only guaranteed that the page is locked.
    + * called with @i_mutex unlocked. For example, when flusher thread is doing
    + * background write-back, it calls 'ubifs_writepage()' with unlocked @i_mutex.
    + * At "normal" work-paths the @i_mutex is locked in 'ubifs_writepage()', e.g.
    + * in the "sys_write -> alloc_pages -> direct reclaim path". So, in
    + * 'ubifs_writepage()' we are only guaranteed that the page is locked.
    *
    * Similarly, @i_mutex is not always locked in 'ubifs_readpage()', e.g., the
    * read-ahead path does not lock it ("sys_read -> generic_file_aio_read ->
    diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
    index 5862dd9..e924dbf 100644
    --- a/fs/ubifs/super.c
    +++ b/fs/ubifs/super.c
    @@ -303,7 +303,7 @@ static int ubifs_write_inode(struct inode *inode, struct writeback_control *wbc)
    mutex_lock(&ui->ui_mutex);
    /*
    * Due to races between write-back forced by budgeting
    - * (see 'sync_some_inodes()') and pdflush write-back, the inode may
    + * (see 'sync_some_inodes()') and background write-back, the inode may
    * have already been synchronized, do not do this again. This might
    * also happen if it was synchronized in an VFS operation, e.g.
    * 'ubifs_link()'.
    --
    1.7.10


    \
     
     \ /
      Last update: 2012-07-25 18:01    [W:4.570 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site