lkml.org 
[lkml]   [2012]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] staging/panel: fix checkpatch warnings
    Date
    Now checkpatch clean.

    $ find drivers/staging/panel -name "*.[ch]"|xargs ./scripts/checkpatch.pl \
    -f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n

    2 WARNING: Single statement macros should not use a do {} while (0) loop

    Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
    ---
    drivers/staging/panel/panel.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
    index 39f9982..d9fec5b 100644
    --- a/drivers/staging/panel/panel.c
    +++ b/drivers/staging/panel/panel.c
    @@ -137,8 +137,8 @@
    #define r_ctr(x) (parport_read_control((x)->port))
    #define r_dtr(x) (parport_read_data((x)->port))
    #define r_str(x) (parport_read_status((x)->port))
    -#define w_ctr(x, y) do { parport_write_control((x)->port, (y)); } while (0)
    -#define w_dtr(x, y) do { parport_write_data((x)->port, (y)); } while (0)
    +#define w_ctr(x, y) (parport_write_control((x)->port, (y)))
    +#define w_dtr(x, y) (parport_write_data((x)->port, (y)))

    /* this defines which bits are to be used and which ones to be ignored */
    /* logical or of the output bits involved in the scan matrix */
    --
    1.7.5.4


    \
     
     \ /
      Last update: 2012-07-25 06:01    [W:0.039 / U:3.932 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site