Messages in this thread | | | Date | Tue, 24 Jul 2012 13:26:39 -0600 | From | Jeff Law <> | Subject | Re: [PATCH v2] posix_types.h: make __NFDBITS compatible with glibc definition |
| |
On 07/24/12 13:24, Linus Torvalds wrote: > On Tue, Jul 24, 2012 at 12:15 PM, Jeff Law <law@redhat.com> wrote: >> >> Please refer to the original discussion where they did evaluate the cost of >> this change and tested that the final change made no difference to the >> generated code. > > Umm. That bugzilla entry seems to be talking about a *sane* change, namely > > - ({ unsigned long int __d = (d); \ > + ({ unsigned long int __d = (unsigned long int) (d); \ > > in __FD_ELT(), which is totally different from the one Josh talks about. Right. Josh's change is necessary to prevent warnings from folks (incorrectly) using posix_types.h instead of select.h after the change in that BZ was made. That's why I originally stated that, arguably, posix_types.h really should go away or just use the definitions provided by glibc.
Jeff
| |