lkml.org 
[lkml]   [2012]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/17] Tools: hv: Represent the ipv6 mask using CIDR notation
    On Tue, Jul 24, 2012 at 09:01:33AM -0700, K. Y. Srinivasan wrote:
    > Transform ipv6 subnet information to CIDR notation.
    >
    > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
    > ---
    > tools/hv/hv_kvp_daemon.c | 45 +++++++++++++++++++++++++++++++++++----------
    > 1 files changed, 35 insertions(+), 10 deletions(-)
    >
    > diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
    > index 2c24ebf..007e698 100644
    > --- a/tools/hv/hv_kvp_daemon.c
    > +++ b/tools/hv/hv_kvp_daemon.c
    > @@ -491,6 +491,15 @@ done:
    > return;
    > }
    >
    > +static unsigned int hweight32(unsigned int *w)
    > +{
    > + unsigned int res = *w - ((*w >> 1) & 0x55555555);
    > + res = (res & 0x33333333) + ((res >> 2) & 0x33333333);
    > + res = (res + (res >> 4)) & 0x0F0F0F0F;
    > + res = res + (res >> 8);
    > + return (res + (res >> 16)) & 0x000000FF;
    > +}

    What's wrong with the hweight32 version we have already in
    <include/asm-generic/bitops/const_hweight.h> which you can include by
    simply by including <asm-generic/bitops.h>?

    --
    Regards/Gruss,
    Boris.


    \
     
     \ /
      Last update: 2012-07-24 18:41    [W:0.024 / U:122.588 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site