lkml.org 
[lkml]   [2012]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Staging: slicoss: Clean up tabs vs spaces in slic.h
On Sun, Jul 22, 2012 at 10:57:09PM +0200, Jesper Juhl wrote:
> Make it match CodingStyle a bit better, tab/space wise.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> drivers/staging/slicoss/slic.h | 751 ++++++++++++++++++++---------------------
> 1 file changed, 374 insertions(+), 377 deletions(-)
>
> diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
> index ebdcc6f..0deb670 100644
> --- a/drivers/staging/slicoss/slic.h
> +++ b/drivers/staging/slicoss/slic.h
> @@ -42,61 +42,62 @@
> #define __SLIC_DRIVER_H__
>
> /* firmware stuff */
> -#define OASIS_UCODE_VERS_STRING "1.2"
> -#define OASIS_UCODE_VERS_DATE "2006/03/27 15:10:37"
> -#define OASIS_UCODE_HOSTIF_ID 3
> +#define OASIS_UCODE_VERS_STRING "1.2"
> +#define OASIS_UCODE_VERS_DATE "2006/03/27 15:10:37"
> +#define OASIS_UCODE_HOSTIF_ID 3

No. The original was far better.

Looking through the rest of the patch, some of these changes are ok,
and some are nonsense.

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-07-23 09:42    [W:0.044 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site