Messages in this thread |  | | | Date | Mon, 23 Jul 2012 08:02:20 +0100 | | From | "Jan Beulich" <> | | Subject | Re: [PATCH] x86: adjust generic_get_mtrr() for 64-bit |
| |
>>> On 06.07.12 at 23:38, Yinghai Lu <yinghai@kernel.org> wrote: > On Fri, Jul 6, 2012 at 7:14 AM, Jan Beulich <JBeulich@suse.com> wrote: >> Needing to deal with potentially large memory configurations, the >> variables here should be "unsigned long" instead of "unsigned int". >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> >> >> --- >> arch/x86/kernel/cpu/mtrr/generic.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> --- 3.5-rc5/arch/x86/kernel/cpu/mtrr/generic.c >> +++ 3.5-rc5-x86-mtrr-generic-types/arch/x86/kernel/cpu/mtrr/generic.c >> @@ -514,8 +514,8 @@ generic_get_free_region(unsigned long ba >> static void generic_get_mtrr(unsigned int reg, unsigned long *base, >> unsigned long *size, mtrr_type *type) >> { >> - unsigned int mask_lo, mask_hi, base_lo, base_hi; >> - unsigned int tmp, hi; >> + unsigned long mask_lo, mask_hi, base_lo, base_hi, tmp; >> + unsigned int hi; > > _lo, _hi means we want it as 32bit. > > or we just change them to u32 to make it more clear ?
Agreed, it's really only "tmp" that needs to be "unsigned long". I'll send out a v2 soon, at once converting lo/hi to u32.
Jan
|  |