Messages in this thread | | | Date | Mon, 23 Jul 2012 19:58:31 +0200 | From | Daniel Mack <> | Subject | Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN |
| |
On 23.07.2012 18:51, Dmitry Torokhov wrote: > On Thu, Jul 19, 2012 at 05:36:12PM +0200, Daniel Mack wrote:
>> Ok, finally I found some time. In general, the patch works fine. The >> only detail I had to amend was the irqflags, which were changed from >> IRQF_TRIGGER_RISING/IRQF_TRIGGER_FALLING to >> IRQF_TRIGGER_HIGH/IRQF_TRIGGER_LOW, which doesn't work as the PXA can't >> deal with level-based IRQs. Changing this back to RISING/FALLING makes >> the driver work again. > > Hmm, but that would mean we need to restore reading the data in open() > to make sure we re-arm IRQ in case somebody touched the screen before it > was opened by userspace...
Hmm, right, that was the reason why I put it there in the first place. Thanks for the heads-up. Would you do it? Want me to?
Daniel
| |