Messages in this thread | | | Date | Mon, 23 Jul 2012 15:33:27 +0200 | From | Miguel Gómez <> | Subject | Re: [PATCH 1/1 v2] classmate-laptop: Add support for Classmate V4 accelerometer. |
| |
El 23/07/12 15:28, Matthew Garrett escribió: > On Wed, Jul 18, 2012 at 03:53:48PM +0200, Miguel Gómez wrote: > >>> 1) reverting the patch in acpica that puts all names in uppercase >>> 2) using a case-insensitive match in acpi bus driver >>> 3) using uppercase name in classmate-laptop driver >> >> I think the easiest and less risky way to fix this is by adding a >> new hardware id (as proposed in the thread's patch), as it doesn't >> add any side effects (that the other solutions might add), and it >> doesn't break the behaviour of the old code. > > I've lost track of the implementation state here - if all names are > upper-cased in acpica, why is this not already matching?
Names are upper-cased in acpica, so the device is reported as FNBT0000. But in the driver it's named FnBT0000, and that's why it doesn't match.
-- Miguel Gómez Igalia - http://www.igalia.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |