Messages in this thread | | | From | Chris Ball <> | Subject | Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure | Date | Sat, 21 Jul 2012 19:23:35 -0400 |
| |
Hi,
On Thu, Jul 12 2012, S, Venkatraman wrote: > On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman <khilman@ti.com> wrote: >> If platform_get_resource_by_name() fails, driver probe is aborted an >> should return an error so the driver is not bound to the device. >> >> However, in the current error path of platform_get_resource_by_name(), >> probe returns zero since the return value (ret) is not properly set. >> With a zero return value, the driver core assumes probe was successful >> and will bind the driver to the device. >> >> Fix this by ensuring that probe returns an error code in this failure >> path. >> >> Signed-off-by: Kevin Hilman <khilman@ti.com> > > Good catch. > Acked-by: Venkatraman S <svenkatr@ti.com>
Thanks, pushed to mmc-next for 3.6.
- Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child
| |