Messages in this thread | | | Subject | Re: [PATCH] dmi: Feed DMI table to /dev/random driver | From | Matt Mackall <> | Date | Fri, 20 Jul 2012 16:03:33 -0500 |
| |
On Fri, 2012-07-20 at 13:15 -0700, Tony Luck wrote: > Send the entire DMI (SMBIOS) table to the /dev/random driver to > help seed its pools. > > Signed-off-by: Tony Luck <tony.luck@intel.com> > --- > > This looks a useful addition to your /dev/random series. There are > lots of platform specific goodies in this table (BIOS version, system > serial number and UUID, count and version number of processors, DIMM > slot population and serial numbers, etc.) > > On the system I tested the patch on the table is 9866 bytes. Is it > OK to dump that much into add_device_randomness() in one shot?
Yes, that's fine. We should also consider doing something similar with various bus enumerations (PCI, USB, SCSI) and hotplug, we might pick up similar goodies. Also, we should feed in the OF device tree on platforms that use it.
-- Mathematics is the supreme nostalgia of our time.
| |