Messages in this thread | | | Date | Fri, 20 Jul 2012 22:08:21 +0545 | Subject | Re: [PATCH v2] leds: add new lp8788 led driver | From | "devendra.aaru" <> |
| |
Hi,
I think a mutex_unlock is missed out,
On Fri, Jul 20, 2012 at 2:28 PM, Kim, Milo <Milo.Kim@ti.com> wrote: > + > +static void lp8788_led_work(struct work_struct *work) > +{ > + struct lp8788_led *led = container_of(work, struct lp8788_led, work); > + enum lp8788_isink_number num = led->isink_num; > + int enable; > + u8 val = led->brightness; > + > + mutex_lock(&led->lock); > + > + switch (num) { > + case LP8788_ISINK_1: > + case LP8788_ISINK_2: > + case LP8788_ISINK_3: > + lp8788_write_byte(led->lp, lp8788_pwm_addr[num], val); > + break; > + default: missed mutex_unlock > + return; > + } > + > + enable = (val > 0) ? 1 : 0; > + if (enable != led->on) > + lp8788_led_enable(led, num, enable); > + > + mutex_unlock(&led->lock); > +} > +
Thanks, Devendra
| |