lkml.org 
[lkml]   [2012]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] staging/comedi/drivers: release allocated I/O region if alloc_private fails
From
On Mon, Jul 2, 2012 at 2:10 PM, Ian Abbott <abbotti@mev.co.uk> wrote:
> On 2012-07-01 14:36, Devendra Naga wrote:
>>
>> if alloc_private fail, we wont' release the I/O region,
>> which was request_region 'ed.
>>
>> release the allocated I/O region if alloc_private fails.
>>
>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
>> ---
>
>
> No. The I/O region will be deallocated in fl512_detach() because
> dev->iobase has been set non-zero. fl512_detach() will be called by the
> comedi core if fl512_attach() returns an error. This is an unusual aspect
> of the comedi drivers.
>
Oh, i didn't see the comedi core, i went and saw that its not freed
up, so actaully driver unload wont' be called if driver attach , probe
fail. so i started sending this patch.

Sorry.
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-

Devendra.


\
 
 \ /
  Last update: 2012-07-02 11:21    [W:0.068 / U:1.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site