Messages in this thread Patch in this message | | | Subject | [PATCH 1/2] regulator: ad5398: Fix min/max current limit boundary checking | From | Axel Lin <> | Date | Tue, 03 Jul 2012 11:01:13 +0800 |
| |
It is ok to request current limit with min_uA < chip->min_uA and max_uA > chip->max_uA.
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/regulator/ad5398.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c index 46d05f3..6a357dc 100644 --- a/drivers/regulator/ad5398.c +++ b/drivers/regulator/ad5398.c @@ -89,9 +89,7 @@ static int ad5398_set_current_limit(struct regulator_dev *rdev, int min_uA, int unsigned short data; int ret; - if (min_uA > chip->max_uA || min_uA < chip->min_uA) - return -EINVAL; - if (max_uA > chip->max_uA || max_uA < chip->min_uA) + if (min_uA > chip->max_uA || max_uA < chip->min_uA) return -EINVAL; selector = DIV_ROUND_UP((min_uA - chip->min_uA) * chip->current_level, -- 1.7.9.5
| |