lkml.org 
[lkml]   [2012]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] fat: Refactor shortname parsing
Date
"Steven J. Magnani" <steve@digidescorp.com> writes:

> On Sat, 2012-06-30 at 05:09 +0900, OGAWA Hirofumi wrote:
>> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
>>
>> >
>> > if (is_vfat)
>> > ptname[i++] = fat_tolower(!nocase, c);
>>
>> Of course, if (!is_vfat). Sorry.
>
> I agree that the nocase logic is confusing, but I'm pretty sure this
> change would break the code.

I might be wrong here though, which place is broken with it?

> 'nocase' is always zero for vfat, which does not recognize that option.
> For msdos, it is zero by default, and 1 if the 'nocase' option was
> specified.
> In all cases it is necessary to copy *something* to ptname.

Looks like, we overwrite bufname by converted bufuname in is_vfat case?

if (isvfat) {
bufuname[j] = 0x0000;
i = fat_uni_to_x8(sb, bufuname, bufname, sizeof(bufname));
}
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


\
 
 \ /
  Last update: 2012-07-02 16:22    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site