Messages in this thread | | | Subject | Re: [PATCH] perf bench: fix confused variable namings and descriptions in mem subsystem | From | Hitoshi Mitake <> | Date | Mon, 02 Jul 2012 18:06:02 +0900 |
| |
Namhyung Kim <namhyung@kernel.org> wrote:
>Hi, > >On Mon, 2 Jul 2012 00:06:23 +0900, Hitoshi Mitake wrote: >> As Namhyung Kim pointed, there are confused namings and descriptions >> of words "cycle" and "clock" in mem-memset.c and mem-memcpy.c. >> >> With the option "-c" (or "--clock", now renamed as "--cycle"), mem >> subsystem measures cost of memset() and memcpy() with cpu-cycles >> event. >> >> But current mem subsystem source code contains lots of confused >> variable namings and descriptions with "clock" (e.g. the variable >> use_clock). This is a very bad style because there is another >software >> event named "cpu-clock". This patch replaces wrong usage of "clock" >to >> "cycle". >> > >Could you fix the Documentation/perf-bench.txt also? > >Thanks, >Namhyung
Oops, sorry. I'll send the modified version later. -- Sent from my Android phone with K-9. Please excuse my brevity.
| |