lkml.org 
[lkml]   [2012]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] leds-88pm860x: use the goto label at data->port
On Mon, Jul 2, 2012 at 4:22 PM, Devendra Naga <devendra.aaru@gmail.com> wrote:
> at the goto lable out: we are doing free of the led data, and returning ret.
> the same we are doing at the data->port < 0 case, so use the goto end and
> assign ret to -EINVAL. this will make the common err path for the
> data->port and led_classdev_register functions.
>

This patch is not wrong, but it'd better we replace kzalloc/kfree to
devm_kzalloc. So we don't care about kfree anymore.
Are interested in doing that?

Thanks,
-Bryan

> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> ---
> drivers/leds/leds-88pm860x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
> index 5b61aaf..538aaa3 100644
> --- a/drivers/leds/leds-88pm860x.c
> +++ b/drivers/leds/leds-88pm860x.c
> @@ -220,8 +220,8 @@ static int pm860x_led_probe(struct platform_device *pdev)
> data->port = pdata->flags;
> if (data->port < 0) {
> dev_err(&pdev->dev, "check device failed\n");
> - kfree(data);
> - return -EINVAL;
> + ret = -EINVAL;
> + goto out;
> }
>
> data->current_brightness = 0;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-leds" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer +86.186-168-78255 Mobile
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com


\
 
 \ /
  Last update: 2012-07-02 12:01    [W:0.059 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site