lkml.org 
[lkml]   [2012]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 2/2] regmap-irq: support different type of irq register
On Thu, Jul 19, 2012 at 09:04:44AM +0000, Kim, Milo wrote:

> + * @irq_type: Interrupt register type. masked or enabled
> */
> struct regmap_irq_chip {
> const char *name;
> @@ -304,6 +311,8 @@ struct regmap_irq_chip {
>
> const struct regmap_irq *irqs;
> int num_irqs;
> +
> + enum regirq_type irq_type;

This naming is very unclear - it's not about the interrupt itself, it's
about the mask for the interrupt. This would more normally be covered
by marking the masks as being inverted rather than something like this.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-07-19 12:01    [W:0.062 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site