lkml.org 
[lkml]   [2012]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/34] vmscan: add shrink_slab tracepoints
On Thu, Jul 19, 2012 at 03:30:17PM -0500, Jonathan Nieder wrote:
> Mel Gorman wrote:
>
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > commit 095760730c1047c69159ce88021a7fa3833502c8 upstream.
> >
> > Stable note: Not tracked in Bugzilla. This is a diagnostic patch that
> > was part of a series addressing excessive slab shrinking after
> > GFP_NOFS failures. There is detailed information on the series'
> > motivation at https://lkml.org/lkml/2011/6/2/42 .
>
> Thanks. Why would we want this particular patch in stable@?

That's a reasonable question and thanks for taking a look at this series.

> It doesn't sound like it fixes a serious issue.
>

You're right, it doesn't. There are a few patches in this series that
were applied because they made other patches easier to apply and this is
one of them. I should have noted this properly. Unlike other patches of
this type in the series, this particular one would have been easy to work
around. How about this as an updated note or would you prefer it was
dropped entirely?

Stable note: This patch makes later patches easier to apply but otherwise
has little to justify it. It is a diagnostic patch that was part
of a series addressing excessive slab shrinking after GFP_NOFS
failures. There is detailed information on the series' motivation
at https://lkml.org/lkml/2011/6/2/42 .

--
Mel Gorman
SUSE Labs


\
 
 \ /
  Last update: 2012-07-20 00:41    [W:0.232 / U:0.540 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site