lkml.org 
[lkml]   [2012]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH 0/1 v2] cpuidle: allow to disable C states of the ladder governor
Rafael,

>>>>>> [..]
>>>>>> I could implement a sanitize mechanism of the ladder governor that
>>>>>> takes care the "disable" variables of all deeper states are set to 1,
>>>>>> if a state is disabled, and those of all lighter states are set to 0,
>>>>>> if a state is enabled. Do you wish me to do that?
>>>>> No, I dont think thats necessary, current code suffices it.
>>>>> The disable flag is knob we are giving to the user . So may be just
>>>>> document the intended use of disable flag working
>>>>> alongside design of ladder governor.
>>>> It's not necessary - but maybe better. Here comes v3 with a sanitizer.
>>>> Is this too ugly?
>>> The v2, with the documentation in place seems sufficient.
>>> Yup, this adds unnecessary fields which are not much use
>>> coz the same can be achieved with just disable flag check.
>> ok, let's take v2.
> Can you please resend the version regarded as the current one?

This is the version that was regarded as the current one (v2).

Changes in v2: A note in the documentation explains why the sysfs
variable "disable" may not always reflect the current situation
and why modifying it may not always work as expected.

-Carsten.



\
 
 \ /
  Last update: 2012-07-19 21:41    [W:0.065 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site