lkml.org 
[lkml]   [2012]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Question about tps65090 mfd driver
From
Hi, Venu.

2012/7/18 Venu Byravarasu <vbyravarasu@nvidia.com>:
> Yes, you are right.
> it was a mistake.
> Will send a patch soon.

I saw your patch about this from https://lkml.org/lkml/2012/7/18/232
because i doesn't subcribe linux-kernel ML yet.

The tps65090 mfd driver has two mfd_cells for "tps65090-pmic" and
"tps65090-regulator". I can find tps65090-regulator driver but cannot find
tps65090-pmic driver.

Is there any reason to exist two mfd_cells?

And one more question.

struct tps65090_platform_data {
int irq_base;
int num_subdevs;
struct tps65090_subdev_info *subdevs;
}
This is platform data struct for tps65090 mfd driver, but num_subdevs
and subdevs are not used in the mfd driver. How do you handle platform
data of tps65090 mfd driver and regulator driver?

Thanks.

>
> Thanks,
> Venu
>
>
>> -----Original Message-----
>> From: Joonyoung Shim [mailto:dofmind@gmail.com]
>> Sent: Wednesday, July 18, 2012 6:14 PM
>> To: Venu Byravarasu
>> Cc: sameo@linux.intel.com; linux-kernel@vger.kernel.org
>> Subject: Question about tps65090 mfd driver
>>
>> Hi,
>>
>> I have one question about tps65090 mfd driver.
>> There are following codes in the drivers/mfd/tps65090.c
>>
>> ...
>> static struct mfd_cell tps65090s[] = {
>> {
>> .name = "tps65910-pmic",
>> },
>> {
>> .name = "tps65910-regulator",
>> },
>> };
>> ...
>>
>> I know tps65090 and tps65910 have each different regulator driver.
>>
>> drivers/regulator/tps65090-regulator.c
>> drivers/regulator/tps65910-regulator.c
>>
>> So, i wonder whether it is right that tps65090 mfd driver has tps65910-xxx.
>>
>> Thanks.
>>
>> --
>> - Joonyoung Shim



--
- Joonyoung Shim


\
 
 \ /
  Last update: 2012-07-19 08:21    [from the cache]
©2003-2011 Jasper Spaans