Messages in this thread | | | Subject | Re: Re: [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls | From | Steven Rostedt <> | Date | Thu, 19 Jul 2012 14:24:52 -0400 |
| |
On Thu, 2012-07-19 at 08:52 -0400, Steven Rostedt wrote: > On Thu, 2012-07-19 at 11:20 +0900, Masami Hiramatsu wrote: > > (2012/07/19 0:59), Steven Rostedt wrote: > > > On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote: > > > > > > Masami, can you give your Reviewed-by tag for this version? Or is there > > > something else needing to be fixed? > > > > No, that is OK for me. I've just missed that... > > > > Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > > > > Thank you! > > > > Thanks! Except I have one more version. Someone offlist gave me some > ideas. > > Here's the diff from the previous patch. > > diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S > index 46caa56..ca5a146 100644 > --- a/arch/x86/kernel/entry_32.S > +++ b/arch/x86/kernel/entry_32.S > @@ -1169,10 +1169,9 @@ ENTRY(ftrace_regs_caller) > movl $__KERNEL_CS,13*4(%esp) > > movl 12*4(%esp), %eax /* Load ip (1st parameter) */ > - movl 0x4(%ebp), %edx /* Load parent ip (2cd parameter) */ > - lea (%esp), %ecx > - pushl %ecx /* Save pt_regs as 4th parameter */ > + movl 0x4(%ebp), %edx /* Load parent ip (2nd parameter) */ > leal function_trace_op, %ecx /* Save ftrace_pos in 3rd parameter */ > + pushl %esp /* Save pt_regs as 4th parameter */ > > GLOBAL(ftrace_regs_call)
I'm adding this as a separate patch under Uros's name.
I'll be posting the full series for pulling either tonight or tomorrow, depending on how it handles all my stress tests.
-- Steve
| |