lkml.org 
[lkml]   [2012]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/5] perf report: Cleanup and refactor hist printing code
Date
Hi,

I'm working on improving perf report. Main goal is adding support for
event-grouping (viewer part) and callchain accumulation (aka sort inclusive).
I'm hoping that I can post an initial series by the end of next week.

But before that, I just want to cleanup the code somewhat since it's a pain
to look at it in the current form. So I added struct hist_period_print (or
a better name?), and let callers configure it dynamically for their needs.
I think this can make it easy to work with the code.

I know that it'll be conflict with Frederic recent changes. But it should be
trivial to resolve them upon this series (or the other way around).

Any comments are welcome.

Thanks,
Namhyung


Namhyung Kim (5):
perf tools: Separate out hist print functions
perf tools: Refactor some functions
perf tools: Introduce hist_period_print functions
perf ui/browser: Use hist_period_print functions
perf gtk/browser: Use hist_period_print functions

tools/perf/Makefile | 4 +-
tools/perf/ui/browsers/hists.c | 102 +++--
tools/perf/ui/gtk/browser.c | 103 ++++-
tools/perf/ui/hist.c | 820 ++++++++++++++++++++++++++++++++++++++++
tools/perf/util/hist.c | 685 +--------------------------------
tools/perf/util/hist.h | 41 +-
6 files changed, 1045 insertions(+), 710 deletions(-)
create mode 100644 tools/perf/ui/hist.c

--
1.7.9.2



\
 
 \ /
  Last update: 2012-07-19 18:21    [W:0.067 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site