lkml.org 
[lkml]   [2012]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] mm/memcg: use exist interface to get css from memcg
    (2012/07/19 18:29), Michal Hocko wrote:
    > On Wed 18-07-12 19:08:54, Wanpeng Li wrote:
    >> use exist interface mem_cgroup_css instead of &mem->css.
    >
    > This interface has been added to enable mem->css outside of
    > mm/memcontrol.c (where we define struct mem_cgroup). There is one user
    > left (hwpoison_filter_task) after recent clean ups.
    >
    > I think we shouldn't spread the usage inside the mm/memcontrol.c. The
    > compiler inlines the function for all callers added by this patch but I
    > wouldn't rely on it. It is also unfortunate that we cannot convert all
    > dereferences (e.g. const mem_cgroup).
    > Moreover it doesn't add any additional type safety. So I would vote for
    > not taking the patch but if others like it I will not block it.
    >

    Agreed.

    -Kame



    \
     
     \ /
      Last update: 2012-07-19 13:01    [W:0.023 / U:30.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site