lkml.org 
[lkml]   [2012]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 22/90] staging: comedi: adv_pci_dio: remove CheckAndAllocCard()
On 2012-07-19 02:34, H Hartley Sweeten wrote:
> This driver creates a linked list of all the pci devices in
> the system while it's looking for a match. It's only use is
> to determine if a device is "free" to use. The pci_is_enabled()
> helper can give us the same information. Use that instead and
> remove the linked list.

As mentioned in my replies to your patches to adv_pci1723 and
adv_pci1710, pci_is_enabled() might not be sufficient. I think it's
better just to take out the free/in-use test.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-




\
 
 \ /
  Last update: 2012-07-19 12:21    [W:0.055 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site